Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 support / Bump tested ruby versions / Clean up #209

Merged
merged 13 commits into from
Apr 30, 2020

Conversation

wpliao1989
Copy link
Contributor

@wpliao1989 wpliao1989 commented Apr 29, 2020

  • Add Rails 6

  • Move Rails 5.0 to Rails 5.2

  • Remove Rails 4.2

  • Bump Ruby versions

  • Fix AePageObjects is not tested against Rails xxx and may behave in an undefined manner. warning

Notes

There are a few deprecation warnings on Ruby 2.7 about keyword arguments. We should address them later.

Change to 2.5.8, 2.6.6 and 2.7.1 to match latest stable ruby versions.
selenium_helper was symlinked which caused a lot of issues.
@wpliao1989 wpliao1989 force-pushed the wlTestAgainstRails6 branch 2 times, most recently from 368ed48 to 8ba4023 Compare April 30, 2020 00:17
@wpliao1989 wpliao1989 force-pushed the wlTestAgainstRails6 branch 3 times, most recently from 50aa888 to 0c99903 Compare April 30, 2020 03:27
@wpliao1989 wpliao1989 mentioned this pull request Apr 30, 2020
@wpliao1989 wpliao1989 force-pushed the wlTestAgainstRails6 branch from 0c99903 to 34dfbb9 Compare April 30, 2020 18:21
@wpliao1989 wpliao1989 force-pushed the wlTestAgainstRails6 branch from 34dfbb9 to bf56fe1 Compare April 30, 2020 18:34
@wpliao1989 wpliao1989 changed the title Add Rails 6 to test matrix and clean things up Rails 6 support / Bump tested ruby versions / Clean up Apr 30, 2020
@wpliao1989 wpliao1989 merged commit f110dfb into master Apr 30, 2020
@wpliao1989 wpliao1989 deleted the wlTestAgainstRails6 branch April 30, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants